Skip to content

Conversation

@AshishViradiya153
Copy link
Contributor

@AshishViradiya153 AshishViradiya153 commented May 11, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Improved error handling for missing datarooms, documents, and folders by displaying user-friendly notifications and redirecting to the appropriate listing pages.
    • API responses now return clear 404 status codes and descriptive error messages when datarooms or documents are not found.
  • Refactor

    • Updated the document page to remove redundant 404 error rendering logic, ensuring a more consistent user experience.

@AshishViradiya153 AshishViradiya153 requested a review from mfts as a code owner May 11, 2025 22:16
@vercel
Copy link

vercel bot commented May 11, 2025

@AshishViradiya153 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 11, 2025

"""

Walkthrough

The changes introduce enhanced error handling for missing datarooms, documents, and folders across client hooks and API endpoints. Client-side hooks now display toast notifications and redirect users when a 404 error occurs. API endpoints return explicit 404 JSON responses for missing resources. The document page component no longer short-circuits rendering on 404 errors.

Changes

File(s) Change Summary
lib/swr/use-dataroom.ts
lib/swr/use-document.ts
lib/swr/use-documents.ts
Added onError callbacks to useSWR hooks for 404 errors: show toast notifications and redirect users to listing pages.
pages/api/teams/[teamId]/datarooms/[id]/index.ts API now returns 404 JSON error response if dataroom is not found instead of a null 200 response.
pages/api/teams/[teamId]/documents/[id]/index.ts API returns 404 JSON error for missing documents and handles custom TeamError exceptions with specific messages.
pages/documents/[id]/index.tsx Removed conditional rendering for 404 errors; the component no longer returns a 404 error page when such errors occur.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ClientHook as useDataroom/useDocument/useFolder Hook
    participant API
    participant Router
    participant Toast

    User->>ClientHook: Request dataroom/document/folder
    ClientHook->>API: Fetch resource by ID
    API-->>ClientHook: 404 Not Found
    ClientHook->>Toast: Show "Not Found" error toast
    ClientHook->>Router: Redirect to listing page
Loading

Poem

🥕
A dataroom lost, a document gone,
Now toasts pop up and guide you on.
APIs respond with truth, not null,
While error pages are less full.
With every hop and gentle cheer,
The rabbit keeps your pathways clear!

"""

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-05-21T17_30_19_129Z-debug-0.log

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between ad7e2b1 and 79cef22.

📒 Files selected for processing (1)
  • lib/swr/use-documents.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • lib/swr/use-documents.ts
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@vercel
Copy link

vercel bot commented May 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 5:34pm

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 0f946e4 and ad7e2b1.

📒 Files selected for processing (3)
  • lib/swr/use-documents.ts (2 hunks)
  • pages/api/teams/[teamId]/datarooms/[id]/index.ts (1 hunks)
  • pages/api/teams/[teamId]/documents/[id]/index.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • pages/api/teams/[teamId]/datarooms/[id]/index.ts
  • pages/api/teams/[teamId]/documents/[id]/index.ts
🧰 Additional context used
🧬 Code Graph Analysis (1)
lib/swr/use-documents.ts (1)
context/team-context.tsx (1)
  • useTeam (64-64)
🔇 Additional comments (1)
lib/swr/use-documents.ts (1)

100-104: LGTM: Improved error handling with redirection.

The addition of error handling for 404 responses with redirection to the documents page aligns with the overall error handling strategy. This provides a better user experience when folders are not found.

@mfts mfts merged commit 3743df5 into mfts:main May 21, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants