Skip to content

Fix: Close Vaul on X button click #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfts merged 1 commit into from
Feb 20, 2025
Merged

Fix: Close Vaul on X button click #1508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions components/datarooms/dataroom-items-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ export function DataroomItemsList({
const [isOverFolder, setIsOverFolder] = useState<boolean>(false);
const [isDragging, setIsDragging] = useState<boolean>(false);

const handleCloseDrawer = () => {
setShowDrawer(false);
};
const { setShowRemoveDataroomDocumentsModal, RemoveDataroomDocumentsModal } =
useRemoveDataroomDocumentsModal({
documentIds: selectedDocuments,
Expand Down Expand Up @@ -413,6 +416,7 @@ export function DataroomItemsList({
open={showDrawer}
onOpenChange={setShowDrawer}
uploads={uploads}
handleCloseDrawer={handleCloseDrawer}
setUploads={setUploads}
rejectedFiles={rejectedFiles}
setRejectedFiles={setRejectedFiles}
Expand Down
4 changes: 4 additions & 0 deletions components/documents/documents-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@ export function DocumentsList({
setSelectedDocuments([]);
setIsOverFolder(false);
};
const handleCloseDrawer = () => {
setShowDrawer(false);
};

const HeaderContent = memo(() => {
if (selectedDocuments.length > 0) {
Expand Down Expand Up @@ -477,6 +480,7 @@ export function DocumentsList({
open={showDrawer}
onOpenChange={setShowDrawer}
uploads={uploads}
handleCloseDrawer={handleCloseDrawer}
setUploads={setUploads}
rejectedFiles={rejectedFiles}
setRejectedFiles={setRejectedFiles}
Expand Down
7 changes: 6 additions & 1 deletion components/upload-notification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export function UploadNotificationDrawer({
setUploads,
rejectedFiles,
setRejectedFiles,
handleCloseDrawer,
}: {
open: boolean;
onOpenChange: (open: boolean) => void;
Expand All @@ -26,6 +27,7 @@ export function UploadNotificationDrawer({
) => void;
rejectedFiles: { fileName: string; message: string }[];
setRejectedFiles: (rejected: { fileName: string; message: string }[]) => void;
handleCloseDrawer: () => void;
}) {
const uploadCount = uploads.length;
const failedCount = rejectedFiles.length;
Expand Down Expand Up @@ -58,7 +60,10 @@ export function UploadNotificationDrawer({
</p>
) : null}
</div>
<DrawerClose className="rounded-full p-1 hover:bg-gray-200 hover:dark:bg-gray-800">
<DrawerClose
className="rounded-full p-1 hover:bg-gray-200 hover:dark:bg-gray-800"
onClick={handleCloseDrawer}
>
<XIcon className="h-6 w-6" />
</DrawerClose>
</DrawerHeader>
Expand Down