Allow metadata object to be non-owning#73
Merged
mfontanini merged 1 commit intomfontanini:masterfrom May 28, 2018
Merged
Conversation
e4e89e6 to
f492614
Compare
Owner
|
Is there a use case for this besides consistency? I'll merge it regardless but I'm just curious. |
Contributor
Author
|
I want to do something similar to what you're doing with your message dr callback...where I create/own the metadata object and the just pass a reference during dr callback along with the message (I'm not passing at all the kafka handle, just its metadata for user-abstraction reasons). Creating the metadata is probably quite resource intensive as librdkafka has to gather all that info for all topics. So I'd rather do it once and then cache it until some "event occurs" like a reassigment. Anyway that's the jist of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self explanatory. Also allows more consistent design to other similar handles