Skip to content

[Memory Leak] Only release header handle if producev returned no errors #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfontanini merged 1 commit into from
Jun 13, 2023
Merged

[Memory Leak] Only release header handle if producev returned no errors #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/producer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,16 @@ void Producer::do_produce(const MessageBuilder& builder,
RD_KAFKA_V_MSGFLAGS(policy),
RD_KAFKA_V_TIMESTAMP(builder.timestamp().count()),
RD_KAFKA_V_KEY((void*)key.get_data(), key.get_size()),
RD_KAFKA_V_HEADERS(headers.release_handle()), //pass ownership to rdkafka
RD_KAFKA_V_HEADERS(headers.get_handle()), //pass ownership to rdkafka
RD_KAFKA_V_VALUE((void*)payload.get_data(), payload.get_size()),
RD_KAFKA_V_OPAQUE(builder.user_data()),
RD_KAFKA_V_END);
// We only want to release the handle on the headers data
// if the rd_kafka_producev function returned no error, otherwise
// the function doesn't take ownership of the headers data.
if(result == RD_KAFKA_RESP_ERR_NO_ERROR) {
headers.release_handle();
}
check_error(result);
}

Expand All @@ -150,10 +156,16 @@ void Producer::do_produce(const Message& message,
RD_KAFKA_V_MSGFLAGS(policy),
RD_KAFKA_V_TIMESTAMP(duration),
RD_KAFKA_V_KEY((void*)key.get_data(), key.get_size()),
RD_KAFKA_V_HEADERS(headers.release_handle()), //pass ownership to rdkafka
RD_KAFKA_V_HEADERS(headers.get_handle()), //pass ownership to rdkafka
RD_KAFKA_V_VALUE((void*)payload.get_data(), payload.get_size()),
RD_KAFKA_V_OPAQUE(message.get_user_data()),
RD_KAFKA_V_END);
// We only want to release the handle on the headers data
// if the rd_kafka_producev function returned no error, otherwise
// the function doesn't take ownership of the headers data.
if(result == RD_KAFKA_RESP_ERR_NO_ERROR) {
headers.release_handle();
}
check_error(result);
}

Expand Down