Skip to content

added type conversion to avoid signed-vs-unsigned-comparison warning #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfontanini merged 2 commits into from
Jan 19, 2019
Merged

added type conversion to avoid signed-vs-unsigned-comparison warning #157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a34955
added type conversion to avoid signed-vs-unsigned-comparison warning
demin80 Jan 16, 2019
755e9f1
added missing return
demin80 Jan 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/cppkafka/utils/buffered_producer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,7 @@ bool BufferedProducer<BufferType, Allocator>::flush(std::chrono::milliseconds ti
};
re_enqueuer(retry_flush_queue, retry_messages_, retry_mutex_);
re_enqueuer(flush_queue, messages_, mutex_);
return true;
}
else {
async_flush();
Expand Down Expand Up @@ -811,7 +812,7 @@ void BufferedProducer<BufferType, Allocator>::do_add_message(BuilderType&& build

// Flush the queues only if a regular message is added. Retry messages may be added
// from rdkafka callbacks, and flush/async_flush is a user-level call
if (queue_kind == QueueKind::Regular && flush_action == FlushAction::DoFlush && (max_buffer_size_ >= 0) && (max_buffer_size_ <= get_buffer_size())) {
if (queue_kind == QueueKind::Regular && flush_action == FlushAction::DoFlush && (max_buffer_size_ >= 0) && (max_buffer_size_ <= (ssize_t)get_buffer_size())) {
if (flush_method_ == FlushMethod::Sync) {
flush();
}
Expand Down