Bug with message leak in BufferedProducer::flush(timeout)#150
Merged
mfontanini merged 2 commits intomfontanini:masterfrom Dec 16, 2018
Merged
Bug with message leak in BufferedProducer::flush(timeout)#150mfontanini merged 2 commits intomfontanini:masterfrom
mfontanini merged 2 commits intomfontanini:masterfrom
Conversation
mfontanini
reviewed
Dec 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently a bug inside
BufferedProducer::flush(timeout)where if the timeout expired before the temporaryflush_queueis completely purged, the remaining unsent messages are deleted when the function returns. The remaining messages must be re-enqueued back.The solution could be made more performant if the
QueueTypeis changed fromdequetolistandlist::splice()is used instead of inserting at the front of thedeque. However this method is not very popular (probably) and deque performs better than a list overall...so not sure if it's worth the hassle.