Add support for Buffer construction via raw arrays #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accelerated
reviewed
Nov 20, 2018
Contributor
accelerated
left a comment
accelerated
left a comment
There was a problem hiding this comment.
Great, thx! You need to remove the const qualifier from the rvalue constructor.
Contributor
|
Not sure this should have been merged. It was already adressed by PR#147. The raw array constructor is duplicated now. |
Owner
|
Ugh true, how did this even compile? |
Owner
|
So yeah no, this didn't compile https://travis-ci.org/mfontanini/cppkafka/jobs/468738999 |
Owner
|
For future reference @accelerated, please don't create a PR that duplicates a fix that another outstanding PR is already fixing. This is still on me for not double checking though. Sorry @tgaldes that your commit had to be reverted! |
Contributor
|
Sure, but i mentioned it in my PR tho. Also the other one had been outstanding for a month and i assumed @tgaldes had given up on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.