-
Notifications
You must be signed in to change notification settings - Fork 218
header support implementation #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
b221997
8c7149d
c17f3e5
ac5d41e
9dbf515
8af2492
06938a1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| /* | ||
| * Copyright (c) 2017, Matias Fontanini | ||
| * All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions are | ||
| * met: | ||
| * | ||
| * * Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * * Redistributions in binary form must reproduce the above | ||
| * copyright notice, this list of conditions and the following disclaimer | ||
| * in the documentation and/or other materials provided with the | ||
| * distribution. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | ||
| * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | ||
| * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
| * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
| * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
| * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
| * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| * | ||
| */ | ||
|
|
||
| #ifndef CPPKAFKA_HEADER_H | ||
| #define CPPKAFKA_HEADER_H | ||
|
|
||
| #include "buffer.h" | ||
| #include <string> | ||
| #include <assert.h> | ||
|
|
||
| namespace cppkafka { | ||
|
|
||
| template <typename BufferType> | ||
| class Header { | ||
| public: | ||
| using ValueType = BufferType; | ||
| Header() = default; | ||
|
|
||
| Header(const std::string& name, | ||
| const BufferType& value); | ||
|
|
||
| Header(const std::string& name, | ||
| BufferType&& value); | ||
|
|
||
| const std::string& get_name() const; | ||
|
|
||
| const BufferType& get_value() const; | ||
|
|
||
| BufferType& get_value(); | ||
|
|
||
| operator bool() const; | ||
|
|
||
| private: | ||
| template <typename T> | ||
| T make_value(const T& other); | ||
|
|
||
| Buffer make_value(const Buffer& other); | ||
|
|
||
| std::string name_; | ||
| BufferType value_; | ||
| }; | ||
|
|
||
| template <typename BufferType> | ||
| bool operator==(const Header<BufferType>& lhs, const Header<BufferType>& rhs) { | ||
| return std::tie(lhs.get_name(), lhs.get_value()) == std::tie(rhs.get_name(), rhs.get_value()); | ||
| } | ||
|
|
||
| template <typename BufferType> | ||
| bool operator!=(const Header<BufferType>& lhs, const Header<BufferType>& rhs) { | ||
| return !(lhs == rhs); | ||
| } | ||
|
|
||
| template <typename BufferType> | ||
| bool operator<(const Header<BufferType>& lhs, const Header<BufferType>& rhs) { | ||
| return std::tie(lhs.get_name(), lhs.get_value()) < std::tie(rhs.get_name(), rhs.get_value()); | ||
| } | ||
|
|
||
| template <typename BufferType> | ||
| bool operator>(const Header<BufferType>& lhs, const Header<BufferType>& rhs) { | ||
| return std::tie(lhs.get_name(), lhs.get_value()) > std::tie(rhs.get_name(), rhs.get_value()); | ||
| } | ||
|
|
||
| template <typename BufferType> | ||
| bool operator<=(const Header<BufferType>& lhs, const Header<BufferType>& rhs) { | ||
| return !(lhs > rhs); | ||
| } | ||
|
|
||
| template <typename BufferType> | ||
| bool operator>=(const Header<BufferType>& lhs, const Header<BufferType>& rhs) { | ||
| return !(lhs < rhs); | ||
| } | ||
|
|
||
| template <typename BufferType> | ||
| Header<BufferType>::Header(const std::string& name, | ||
| const BufferType& value) | ||
| : name_(name), | ||
| value_(make_value(value)) { | ||
| assert(!name.empty()); | ||
|
||
| } | ||
|
|
||
| template <typename BufferType> | ||
| Header<BufferType>::Header(const std::string& name, | ||
| BufferType&& value) | ||
| : name_(name), | ||
| value_(std::move(value)) { | ||
| assert(!name.empty()); | ||
| } | ||
|
|
||
| template <typename BufferType> | ||
| const std::string& Header<BufferType>::get_name() const { | ||
| return name_; | ||
| } | ||
|
|
||
| template <typename BufferType> | ||
| const BufferType& Header<BufferType>::get_value() const { | ||
| return value_; | ||
| } | ||
|
|
||
| template <typename BufferType> | ||
| BufferType& Header<BufferType>::get_value() { | ||
| return value_; | ||
| } | ||
|
|
||
| template <typename BufferType> | ||
| Header<BufferType>::operator bool() const { | ||
| return !value_.empty(); | ||
| } | ||
|
|
||
| template <> | ||
| inline | ||
| Header<Buffer>::operator bool() const { | ||
| return value_.get_size() > 0; | ||
| } | ||
|
|
||
| template <typename BufferType> | ||
| template <typename T> | ||
| T Header<BufferType>::make_value(const T& other) { | ||
| return other; | ||
| } | ||
|
|
||
| template <typename BufferType> | ||
| Buffer Header<BufferType>::make_value(const Buffer& other) { | ||
| return Buffer(other.get_data(), other.get_size()); | ||
| } | ||
|
|
||
| } //namespace cppkafka | ||
|
|
||
| #endif //CPPKAFKA_HEADER_H | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
nameis being stored here, I would normally take it by value and thenstd::moveit.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BufferType is also stored...shouldn't it also in this case be passed by value and moved ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pls comment on this...I'm not sure if you also want the BufferType to be passed by value instead of lvalue/rvalue ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given a
BufferTypecan't be moved automatically, I don't think this one should take a value. Probably just have both constructors take a string by value.