Skip to content

Conversation

@mfl28
Copy link
Owner

@mfl28 mfl28 commented Jul 23, 2023

  • Fixes handling of partial navigation key-combination release. Images now load correctly even if only a part of the navigation key-combination is released.
  • Updates and extends unit tests.

Fixes #77 .

@mfl28 mfl28 self-assigned this Jul 23, 2023
@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.17 🎉

Comparison is base (0fcad1e) 85.93% compared to head (75371ee) 86.10%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #78      +/-   ##
============================================
+ Coverage     85.93%   86.10%   +0.17%     
- Complexity     1413     1425      +12     
============================================
  Files            92       92              
  Lines          5773     5787      +14     
  Branches        524      524              
============================================
+ Hits           4961     4983      +22     
+ Misses          551      545       -6     
+ Partials        261      259       -2     
Impacted Files Coverage Δ
...mfl28/boundingboxeditor/controller/Controller.java 78.45% <100.00%> (+0.52%) ⬆️
...r/controller/utils/KeyCombinationEventHandler.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mfl28 mfl28 merged commit 6f8a666 into master Jul 23, 2023
@mfl28 mfl28 deleted the bugfix/fix-partial-navigation-key-combination-release-handling branch July 23, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Partial release of navigation key combination does not trigger image loading

2 participants