Skip to content

Conversation

@mfl28
Copy link
Owner

@mfl28 mfl28 commented Feb 26, 2023

  • Sets shape popover smallest side length to 25% of corresponding screen side length. This leads to more consistent popover sizes and improves popover-displaying of small shapes.
  • Popover is no longer displayed for very small/empty shapes (where width/height ~0).

Closes #54 .

@mfl28 mfl28 self-assigned this Feb 26, 2023
@mfl28 mfl28 changed the title Improve shape tree cell popver displaying Improve shape tree cell popover displaying Feb 26, 2023
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.03 ⚠️

Comparison is base (b5d30dc) 85.76% compared to head (6dacdc3) 85.74%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
- Coverage     85.76%   85.74%   -0.03%     
  Complexity     1404     1404              
============================================
  Files            92       92              
  Lines          5740     5745       +5     
  Branches        519      521       +2     
============================================
+ Hits           4923     4926       +3     
  Misses          560      560              
- Partials        257      259       +2     
Impacted Files Coverage Δ
...8/boundingboxeditor/ui/WorkspaceSplitPaneView.java 81.81% <50.00%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mfl28 mfl28 merged commit a840b1c into master Mar 3, 2023
@mfl28 mfl28 deleted the feature/improve-shape-tree-cell-popover-displaying branch March 3, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve shape tree cell popover displaying

2 participants