Treat Meziantou.Framework.Assertions.Assert as non-culture sensitive#1202
Merged
Merged
Conversation
…in UseStringComparisonAnalyzer Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 26, 2026
Closed
Bump Meziantou.Analyzer from 3.0.103 to 3.0.115
Analogy-LogViewer/Analogy.LogViewer.OpenTelemetry#56
Closed
Closed
This was referenced Jul 10, 2026
Open
Open
Open
Open
Bump Meziantou.Analyzer from 3.0.103 to 3.0.123
Analogy-LogViewer/Analogy.LogViewer.OpenTelemetry#66
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
UseStringComparisonAnalyzer(MA0001/MA0002) already treatsXunit.Assertmethods as non-culture sensitive -- meaning when aStringComparisonoverload exists it reports MA0001 ("use an overload with StringComparison") rather than MA0002 ("avoid culture-sensitive method"). This PR extends the same treatment toMeziantou.Framework.Assertions.Assert.Changes
UseStringComparisonAnalyzer.cs: Added a_meziantouFrameworkAssertSymbolfield and a check for it inIsNonCultureSensitiveMethod, mirroring the existingXunit.Asserthandling.UseStringComparisonAnalyzerNonCultureSensitiveTests.cs: Added a test verifying MA0001 is reported (not MA0002) forMeziantou.Framework.Assertions.Assertmethods that have aStringComparisonoverload. The type is defined inline in the test source, following the same pattern used forNewtonsoft.Json.Linq.JObjecttests.