Optimize analyzer hot paths and metadata lookups#1144
Merged
Conversation
Reduce analyzer allocations and repeated metadata lookups in hot paths. - Replace LINQ-based helpers with loop-based implementations in core internals - Hoist GetBestTypeByMetadataName calls into compilation start for targeted analyzers - Optimize LINQ analyzer diagnostic property construction and OrderBy method mapping - Cache NamedParameterAnalyzer configuration keys and compiled regex instances Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 11, 2026
Closed
IhateTrains
pushed a commit
to ParadoxGameConverters/ImperatorToCK3
that referenced
this pull request
May 12, 2026
Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 3.0.77 to 3.0.79. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 3.0.79 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.79> ## What's Changed * Document comparison page maintenance expectations by @meziantou in meziantou/Meziantou.Analyzer#1146 * Allow MA0196 inheritdoc on constructors matching base signatures by @meziantou in meziantou/Meziantou.Analyzer#1149 * Add annotation-based exclusions for MA0042 and MA0045 by @meziantou in meziantou/Meziantou.Analyzer#1148 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.78...3.0.79 ## 3.0.78 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.78> ## What's Changed * Optimize analyzer hot paths and metadata lookups by @meziantou in meziantou/Meziantou.Analyzer#1144 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.77...3.0.78 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@3.0.77...3.0.79). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced May 12, 2026
This was referenced May 16, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Analyzer callbacks run on every compilation and frequently during editing. Several hot paths were doing repeated LINQ enumerations, per-callback metadata type resolution, and repeated regex/config string work, creating avoidable CPU and allocation overhead.
What changed
MethodSymbolExtensions: replacedAny()/First()on explicit interface implementations with directLength/index access.ContextExtensions: removed multiple re-enumerations of source locations when reporting diagnostics.TypeSymbolExtensions: replaced LINQ predicate-based checks with loop-based implementations for interface and attribute lookups.OptimizeLinqUsageAnalyzerto reduce diagnostic-property allocations by using dictionary builders and helper creators, and replacedReplace("OrderBy", "ThenBy")with explicit method-name mapping.NamedParameterAnalyzerto cache config keys as static fields and cache compiled regex instances per compilation-start context.GetBestTypeByMetadataNamelookups out of hot callbacks into compilation start for targeted analyzers (naming/design/usage/perf rules touched in this branch).Notes for reviewers
These are intended as behavior-preserving perf refactors. The changes focus on reducing hot-path allocations and repeated metadata lookups without changing diagnostics semantics.
Validation
dotnet builddotnet test tests/Meziantou.Analyzer.Test/Meziantou.Analyzer.Test.csprojdotnet test tests/Meziantou.Analyzer.Test/Meziantou.Analyzer.Test.csproj /p:RoslynVersion=roslyn4.2 --filter 'FullyQualifiedName~AddOverloadWithSpanOrMemoryAnalyzerTests|FullyQualifiedName~AttributeNameShouldEndWithAttributeAnalyzerTests|FullyQualifiedName~AvoidLockingOnPubliclyAccessibleInstanceAnalyzerTests|FullyQualifiedName~DoNotUseEqualityComparerDefaultOfStringAnalyzerTests|FullyQualifiedName~DontTagInstanceFieldsWithThreadStaticAttributeAnalyzerTests|FullyQualifiedName~EventArgsNameShouldEndWithEventArgsAnalyzerTests|FullyQualifiedName~EventsShouldHaveProperArgumentsAnalyzerTests|FullyQualifiedName~ExceptionNameShouldEndWithExceptionAnalyzerTests|FullyQualifiedName~MarkAttributesWithAttributeUsageAttribute|FullyQualifiedName~NamedParameterAnalyzerTests|FullyQualifiedName~NonFlagsEnumsShouldNotBeMarkedWithFlagsAttributeAnalyzerTests|FullyQualifiedName~OptimizeLinqUsageAnalyzer'dotnet run --project src/DocumentationGeneratorA full Roslyn 4.2 run in this environment still reports one unrelated existing failure (
DoNotNaNInComparisonsAnalyzerTests.Comparisons_CodeFix_Half,NullReferenceException).