Skip to content

Conversation

@italojs
Copy link
Member

@italojs italojs commented Apr 30, 2025

@netlify
Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for v3-meteor-api-docs ready!

Name Link
🔨 Latest commit a15a0ad
🔍 Latest deploy log https://app.netlify.com/sites/v3-meteor-api-docs/deploys/6814ec15a8467f0007c90417
😎 Deploy Preview https://deploy-preview-13721.docs.meteor.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for v3-migration-docs canceled.

Name Link
🔨 Latest commit f924c85
🔍 Latest deploy log https://app.netlify.com/sites/v3-migration-docs/deploys/68123ba1ecf39a000817e33c

@italojs italojs changed the base branch from devel to release-3.3 April 30, 2025 15:08
@italojs italojs requested review from Copilot and nachocodoner April 30, 2025 15:33

This comment was marked as resolved.

@italojs italojs changed the base branch from release-3.3 to devel April 30, 2025 15:42
@italojs italojs changed the title ReDoS Vulnerability in ddp-server/_clientAddress via x-forwarded-for Header ReDoS Vulnerability Apr 30, 2025
@nachocodoner nachocodoner changed the title ReDoS Vulnerability Refactor IP address parsing on Webapp Apr 30, 2025
@StorytellerCZ
Copy link
Collaborator

Maybe this should be released as a patch?

@StorytellerCZ StorytellerCZ added this to the Release 3.3 milestone May 1, 2025
@italojs italojs changed the base branch from devel to release-3.2.1 May 2, 2025 14:33
- Enhanced the handling of comma-separated values in Session._clientAddress.
- Added explicit trimming of IP addresses using a map function.
- Updated validation to ensure an exact match for httpForwardedCount.
- Bumped package version from 3.1.0 to 3.1.1.
- Created a changelog to document these changes.
@ShiyuBanzhou
Copy link

Thanks again for looking into and addressing the ReDoS vulnerability I previously reported regarding the _clientAddress method in livedata_server.js (originally Issue #13713).
Now that a fix has been implemented, I just had a quick question regarding tracking.
Given that this vulnerability could affect production applications where HTTP_FORWARDED_COUNT is configured, would the team consider requesting a CVE ID for this resolved issue? Having a CVE identifier would be helpful for standardized tracking and awareness within the security community.
Of course, this depends entirely on the team's assessment and security policy. I just wanted to raise the possibility for consideration.
Thanks again for your time and effort!

@italojs italojs merged commit f7ea681 into release-3.2.1 May 2, 2025
10 checks passed
@StorytellerCZ
Copy link
Collaborator

@italojs I think we can release just the package, no need to have an entire Meteor release.

@nachocodoner
Copy link
Member

I think a release bump is best for a core package. It will notify everyone, especially if we recommend it, and ensure this important change is seen.ñ and applied in one update.

With minor server bumps is more tricky to get your project updated.

@nachocodoner nachocodoner deleted the fix/reddos branch May 3, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants