-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Refactor IP address parsing on Webapp #13721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for v3-meteor-api-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v3-migration-docs canceled.
|
|
Maybe this should be released as a patch? |
- Enhanced the handling of comma-separated values in Session._clientAddress. - Added explicit trimming of IP addresses using a map function. - Updated validation to ensure an exact match for httpForwardedCount. - Bumped package version from 3.1.0 to 3.1.1. - Created a changelog to document these changes.
|
Thanks again for looking into and addressing the ReDoS vulnerability I previously reported regarding the _clientAddress method in livedata_server.js (originally Issue #13713). |
|
@italojs I think we can release just the package, no need to have an entire Meteor release. |
|
I think a release bump is best for a core package. It will notify everyone, especially if we recommend it, and ensure this important change is seen.ñ and applied in one update. With minor server bumps is more tricky to get your project updated. |
fix: https://github.com/meteor/meteor/issues/13713