Skip to content

Conversation

@tonyboylehub
Copy link
Contributor

Removes the NFT storage plugin from umi packages.

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025

⚠️ No Changeset found

Latest commit: 83f71cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
umi-docs Ready Ready Preview Comment Nov 6, 2025 10:38pm

@coderabbitai
Copy link

coderabbitai bot commented Nov 6, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Summary by CodeRabbit

  • Chores
    • Removed the umi-uploader-nft-storage package entirely from the monorepo. This package provided NFT Storage uploader integration and has been deleted along with all associated source code, build configuration, tests, and documentation. Users currently using this functionality will need to identify and implement alternative file upload solutions for their projects.

Walkthrough

The entire @metaplex-foundation/umi-uploader-nft-storage package is removed, including source code, configuration files, documentation, and tests. No files remain in the package directory.

Changes

Cohort / File(s) Summary
Configuration & Metadata
package.json, tsconfig.json, babel.config.json, rollup.config.js
Build and package configuration files deleted, removing npm metadata, TypeScript compilation settings, Babel overrides, and Rollup bundling setup.
Documentation
CHANGELOG.md, README.md
Package documentation removed, including version history and usage instructions.
Source Implementation
src/BlockstoreCarReader.ts, src/createNftStorageUploader.ts, src/plugin.ts, src/utils.ts, src/index.ts
All source code deleted, including the NFT.Storage uploader factory, plugin integration, CAR reader implementation, and utility functions for URI conversion and DAG encoding.
Tests & Test Configuration
test/NftStorageUploader.test.ts, test/tsconfig.json
Test suite and test-specific TypeScript configuration removed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–25 minutes

  • Rationale: While the changes themselves are homogeneous (complete package deletion), the scope is substantial and the implications require verification:
    • Confirm intentional package deprecation or migration
    • Verify no dependent internal packages or projects rely on this uploader
    • Ensure migration guidance exists for external consumers
    • Validate that the removal does not break downstream code or build pipelines

Suggested reviewers

  • blockiosaurus
  • brandontulsi
  • nhanphan

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'remove nft storage from umi' clearly and concisely describes the main change - the deletion of the NFT storage package and plugin from the umi monorepo.
Description check ✅ Passed The description 'Removes the NFT storage plugin from umi packages.' is directly related to the changeset, which comprehensively removes the packages/umi-uploader-nft-storage package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MarkSackerberg
Copy link
Contributor

Thank you!
Is it correct, that the package is still mentioned in the general pnpm-lock.yaml? I assume we should regenerate it, so that the removed package is also removed from that yaml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants