Skip to content

Conversation

@danenbm
Copy link
Contributor

@danenbm danenbm commented Oct 29, 2024

This PR is not intended to be merged and is created for conveniently running the CI and viewing the diff. This svm branch is the branch intended to hold the code that runs on the other SVMs.

Notes

  • For Bubblegum V1 instructions, this change allows either spl-account-compression/spl-noop OR mpl-account-compression/mpl-noop to be used, since on other SVMs only mpl-account-compression and mpl-noop are deployed.
    • This was the original design when we considered running just one binary on Solana and other SVMs, but now we plan to just keep separate branches for Solana and other SVMs.
    • The program may be changed in the future to require mpl-account-compression and mpl-noop for V1 instructions on the SVM branch, but for now it is convienient to leave it this way because it allows all the same tests to run using the unchanged JS SDK with its default program values.
    • Note that Bubblegum V2 instructions always use mpl-account-compression and mpl-noop no matter if on Solana or other SVMs.
    • On other SVMs mpl-account-compression and mpl-noop must be supplied to override the default compression programs on V1 instructions.
      • The getCompressionProgramsForV1Ixs helper in the JS SDK was created to detect and provide the correct compression programs on other SVMs.
      • See createTree.test.ts and transfer.test.ts for example usage for V1 instructions. Note the helper is never needed for V2 instructions.

* Check compression programs at runtime

* Update Cargo.lock

* Regenerate IDL and SDKs

* Add test for new programs and update program IDs

* Use MPL-specific types instead of assuming spl-account-compression types are compatible

* Use mpl-account-compression published versions

Update spl-account-compression version

Use Node type from spl-concurrent-merkle-tree crate

* Add idl-build feature

* Remove Anchor idl-build feature and remove account compression dependencies that use it

* Temporarily skip different compression program test

* fix ts lint issue

* Download mpl-account-compression programs and reactivate test

* Add tests

* Remove log wrapper validation in decompress as it's unused

* Update to latest spl-account-compression

* Update program download script
@vercel
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mpl-bubblegum-js-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 6:44pm

* Add SDK helper to choose compression programs

* Change variable name
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 26, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Plus other SVM adjustments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants