Fix commit data; author, missing file changes. #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Harring <[email protected]>
Signed-off-by: Brian Harring <[email protected]>
Signed-off-by: Brian Harring <[email protected]>
Fixes * added boolean deleted and created fields per v3 spec. These indicate if it's a ref deletion, new ref created, etc. * fixed the exception for deletion events * forced data annotation via dataclass, thus documenting the event structure. I did this explicitly because there are no tests and I had to rework a lot of this, so might as well use a dataclass to ensure I didn't drop any event data. This is not runtime enforcement however. * fixed the comparison urls sent for a ref creation event. This is larger than intended, but the data validation I had to shove in to verify I didn't break anything. The result is simpler/cleaner however. Signed-off-by: Brian Harring <[email protected]>
This is what was masking the failure in handling deletion events and certain creation events. Signed-off-by: Brian Harring <[email protected]>
See pr metajack#27 mostly addressed this, but this version is more paranoid. When this lands, metajack#27 can be closed out. Signed-off-by: Brian Harring <[email protected]>
Note: this actually fails on the first commit in history; diff-tree is against the parent. It's edge case, but it exists. This is a seperated PR from metajack#29 for review reasons. When this and that lands, issue metajack#28 can be closed. Signed-off-by: Brian Harring <[email protected]>
ferringb
force-pushed
the
fix-commit-data
branch
2 times, most recently
from
8120793 to
d35cbc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review this after #29 lands. It's directly built on top of that.
See issue #28 ; the commit "added, removed" etc data wasn't coming through, and author name and email parsing was generally horked. Both were regex issues which I either replaced or rewrote.
For the name and email parsing, this is obvious; check the commit in this PR.
Note there is a subtle fix in here- for the first file mutation data,
diff-treewill not properly reference the parent since there is no parent. IE, it gives back no changed files even if obviously the first commit adds files. The solution is to force it to diff against the hardcoded SHA for repository initialization.Don't ask me how I know of this gotcha, but it's bit me in the ass before, thus I noticed it.
Other points of note:
-Mwas added so renames are actually detected.gitfunction was allowing non-zero exit code from git- bad calls. This is why the ref deletion event was exploding further down the stack for example. I changed this to explode if a git call fails.diff-treeresults that should be impossible for this code usage.