MBS-13898: Show existing primary alias in alias edit form and alias edits#3690
Draft
reosarevok wants to merge 2 commits intometabrainz:masterfrom
Draft
MBS-13898: Show existing primary alias in alias edit form and alias edits#3690reosarevok wants to merge 2 commits intometabrainz:masterfrom
reosarevok wants to merge 2 commits intometabrainz:masterfrom
Conversation
This should make it easier to decide whether it makes sense to mark an alias as primary, by showing what it would be replacing (or that there is no primary for that locale yet).
reosarevok
force-pushed
the
MBS-13898
branch
from
201b570 to
efc5dce
Compare
reosarevok
force-pushed
the
MBS-13898
branch
from
efc5dce to
433259c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement MBS-13898
Description
The first commit displays the existing primary alias for the selected locale when adding or editing aliases. This should make it easier to decide whether it makes sense to mark an alias as primary, by showing what it would be replacing (or that there is no primary for that locale yet).
PENDING: The second commit displays the original primary alias on alias edits that would replace it.
Testing
For the form display, manually, checking that the right message appears for the right state of the form.
PENDING: edit display.