MBS-13716: Upgrade React to v19#3345
Closed
mwiencek wants to merge 2 commits intometabrainz:masterfrom
Closed
Conversation
mwiencek
force-pushed
the
react-19
branch
2 times, most recently
from
41d806a to
f5c4131
Compare
mwiencek
changed the title
https://react.dev/blog/2024/04/25/react-19 https://react.dev/blog/2024/04/25/react-19-upgrade-guide It seems that a new version of the react-dom libdefs have not been published to flow-typed yet. I simply moved the existing v18 file and removed all removed functions. I didn't add any of the new functions (we don't use them yet). A strange failure occurs in External_Links_Editor.json5 with this upgrade; typing long URLs too quickly seems to trigger "Maximum update depth exceeded" within React. I can't reproduce it by hand, so I'm just updating the test to use `setInputValueForReact` to simulate pasting the URL.
The 3.x version doesn't work at all with our Selenium TAP output for some reason. It just outputs nothing. 5.0.4 works fine.
Member
Author
|
This is now included as part of #3621, which was blocking the upgrade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://react.dev/blog/2024/04/25/react-19
https://react.dev/blog/2024/04/25/react-19-upgrade-guide
It seems that a new version of the react-dom libdefs have not been published to flow-typed yet. I simply moved the existing v18 file and removed all removed functions. I didn't add any of the new functions (we don't use them yet).
--
I'd primarily like to perform this upgrade now in order to use the new react-compiler.