Skip to content

Conversation

@SalmanMohammadi
Copy link
Contributor

@SalmanMohammadi SalmanMohammadi commented Jun 5, 2025

This addresses a few recent issues surrounding our generation API.
Credit for the complete example in the generate docstring goes to @ebsmothers.

Closes #2590. Addresses #2769. Closes #2749

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2787

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cf78622 with merge base da507a0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2025
@SalmanMohammadi SalmanMohammadi merged commit c7a92e4 into meta-pytorch:main Jun 5, 2025
14 checks passed
@SalmanMohammadi SalmanMohammadi deleted the generation_fixes branch June 5, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The first token generation does not use custom_generate_next_token _generation token mask error

3 participants