Add on_eval_epoch_end as a valid hook to TorchSnapshotSaver#826
Add on_eval_epoch_end as a valid hook to TorchSnapshotSaver#826dorukhansergin wants to merge 1 commit intometa-pytorch:masterfrom
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D57083777 |
…orch#826) Summary: When `TorchSnapshotSaver` is used with `save_every_n_eval_epochs > 0` and `best_checkpoint_config`, this hook is invoked. https://www.internalfb.com/code/fbsource/[a8a4a7fba9a8a93af7382fa12e669c066f41024f]/fbcode/torchtnt/framework/callbacks/base_checkpointer.py?lines=273 However, it fails due to not being considered a valid hook. This diff fixes that Differential Revision: D57083777
d768930 to
1ccdf82
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57083777 |
|
Hi @dorukhansergin! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Summary:
When
TorchSnapshotSaveris used withsave_every_n_eval_epochs > 0andbest_checkpoint_config, this hook is invoked.https://www.internalfb.com/code/fbsource/[a8a4a7fba9a8a93af7382fa12e669c066f41024f]/fbcode/torchtnt/framework/callbacks/base_checkpointer.py?lines=273
However, it fails due to not being considered a valid hook. This diff fixes that
Differential Revision: D57083777