Make test_utils.py fork-safe for torchelastic #1030
Open
amorehead wants to merge 1 commit intometa-pytorch:masterfrom
Open
Make test_utils.py fork-safe for torchelastic #1030amorehead wants to merge 1 commit intometa-pytorch:masterfrom
test_utils.py fork-safe for torchelastic #1030amorehead wants to merge 1 commit intometa-pytorch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Makes
test_utils.py(andtorchtntin general) safe to usestart_method=forkfor multi-GPU training withtorchelastic. An example of a project that would benefit from this change isfairchem, which uses bothtorchelasticandtorchtntin conjunction for multi-GPU training.Test plan:
I verified that making this change allows me to train models within the
fairchemcodebase whenstart_method=forkforelastic_launch. Without this change, a CUDA context will be created within the parent process of any Python package that importstorchtnt, which would subsequently make training withforkimpossible when using multiple GPUs in parallel.Fixes:
Together with this fairchem PR, this will fix crashes related to multi-GPU (local, not SLURM) model training using the
fairchemcodebase whenstart_method=fork.