Skip to content

Conversation

@saitcakmak
Copy link
Contributor

Summary: Allows passing in a callable that generates the perturbations for any given X, thus supporting heteroscedastic perturbations.

Differential Revision: D34320700

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Feb 17, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34320700

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1088 (71e538d) into main (9af214f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1088   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          113       113           
  Lines         9570      9575    +5     
=========================================
+ Hits          9570      9575    +5     
Impacted Files Coverage Δ
botorch/models/transforms/input.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af214f...71e538d. Read the comment docs.

Args:
perturbation_set: An `n_p x d`-dim tensor denoting the perturbations
to be added to the inputs.
to be added to the inputs. Alternatively, this can be a callable that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the type of the arg then to be Union[Tensor, Callable[[Tensor], Tensor]?

…orch#1088)

Summary:
Pull Request resolved: meta-pytorch#1088

Allows passing in a callable that generates the perturbations for any given `X`, thus supporting heteroscedastic perturbations.

Reviewed By: Balandat

Differential Revision: D34320700

fbshipit-source-id: f41711e01fa284f517ed620d1859bcd4d91be129
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34320700

@saitcakmak saitcakmak deleted the export-D34320700 branch March 1, 2022 03:27
@saitcakmak saitcakmak mentioned this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants