fix(ui): removed internet hosted fonts from app #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
Copilot finished reviewing on behalf of
danditomaso
November 13, 2025 23:04
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes external CDN dependencies for fonts and switches to self-hosted variable fonts to improve performance, reliability, and reduce reliance on third-party services. The changes eliminate remote font loading from rsms.me and jsdelivr.net CDNs.
- Added local
@font-facedeclarations for Inter variable fonts (normal and italic variants) - Removed external font stylesheet links from HTML
- Updated monospace font stack to use system fonts only (removed Cascadia Code)
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web/src/index.css | Added self-hosted Inter variable font declarations and updated monospace font stack |
| packages/web/index.html | Removed external CDN links for Inter and Cascadia Code fonts |
| packages/web/src/components/generic/Mono.tsx | Removed font-mono class from monospace text component |
| packages/web/src/components/UI/Typography/Code.tsx | Removed font-mono class from inline code component |
| packages/web/public/fonts/InterVariable.woff2 | Added self-hosted Inter variable font file |
| packages/web/public/fonts/InterVariable-Italic.woff2 | Added self-hosted Inter italic variable font file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the way fonts are loaded and used in the web application to improve performance and reliability. It removes external font dependencies and switches to self-hosted variable fonts for the sans-serif typeface, while also simplifying the usage of monospace fonts in code components.
Font loading and usage improvements:
index.html, eliminating reliance on third-party CDNs.@font-facedeclarations for the Inter variable font (normal and italic) inindex.css, enabling self-hosted font loading.--font-monoto remove Cascadia Code, relying on system monospace fonts instead.Code component styling simplification:
font-monoclass from theCodeandMonocomponents, ensuring they use the default monospace fonts defined in CSS. (Code.tsx,Mono.tsx) [1] [2]Related Issues
Fixes #937
Screenshots (if applicable)
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)