rust-toolchain.toml: Upgrade to nightly-2024-04-01#943
Merged
Conversation
kkysen
force-pushed
the
kkysen/update-rustc
branch
from
23707c3 to
fa6df4f
Compare
randomPoison
approved these changes
Apr 1, 2024
Collaborator
randomPoison
left a comment
randomPoison
left a comment
There was a problem hiding this comment.
Thanks for fixing this. I've also noticed the warnings from rust-analyzer, will be nice to have those cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-analyzerhas been showing me a ton of warnings lately, things likenon_camel_case_types, which we allow forrustc, and which I realized is due to therust-analyzerversion being new, and ourrustctoolchain being old. Upgrading it to the latest nightly fixes this. These warnings are especially annoying as they slow down my edit and compile cycle, and we are due for an upgrade anyways, though hopefully we can go tostablenext (once #620 is merged, though it hasn't been enough of a priority).We can also replace the
target_arch = "arm"-dependent#![feature(stdsimd)]with the much more specific and more likely to stabilize soon#![feature(stdarch_arm_feature_detection)].cstr!withc""literals when 1.77 is released #623.