Update RTSP tutorial #101
Merged
Update RTSP tutorial #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noarkhh
force-pushed
the
update-rtsp-tutorial
branch
from
394cdc4 to
441efee
Compare
Noarkhh
force-pushed
the
update-rtsp-tutorial
branch
from
441efee to
0325c72
Compare
varsill
requested changes
Nov 3, 2025
broadcasting/10_RTSP_Pipeline.md
Outdated
Comment on lines
1
to
3
| As explained in the [Architecture chapter](08_RTSP_Architecture.md), the pipeline will consist of a RTSP Source and a HLS Sink. | ||
|
|
||
| The initial pipeline will consist of the `RTSP Source`, which will start establishing the connection with the RTSP server, and the `HLS Sink Bin`. For now we won't connect this elements in any way, since we don't have information about what tracks we'll receive from the RTSP server which we're connecting with. |
Collaborator
There was a problem hiding this comment.
I think these first two sentences are almost the same
broadcasting/10_RTSP_Pipeline.md
Outdated
| def handle_init(_context, options) do | ||
| spec = [ | ||
| child(:source, %Membrane.RTSP.Source{ | ||
| transport: {:udp, options.port, options.port + 5}, |
Contributor
Author
There was a problem hiding this comment.
It defines a range of ports to use, +5 just to be safe if some of them turn out to be in use
Collaborator
There was a problem hiding this comment.
let's give it some name, perhaps let's add a module's attribute like @port_range_size or sth
Noarkhh
force-pushed
the
update-rtsp-tutorial
branch
from
7831db1 to
4d848b0
Compare
varsill
reviewed
Nov 12, 2025
broadcasting/10_RTSP_Pipeline.md
Outdated
| As explained in the [Architecture chapter](08_RTSP_Architecture.md), the pipeline will consist of a RTSP Source and a HLS Sink. | ||
|
|
||
| The initial pipeline will consist of the `RTSP Source`, which will start establishing the connection with the RTSP server, and the `HLS Sink Bin`. For now we won't connect this elements in any way, since we don't have information about what tracks we'll receive from the RTSP server which we're connecting with. | ||
| As explained in the [Architecture chapter](08_RTSP_Architecture.md), the pipeline will consist of an RTSP Source and an HLS Sink Bin. For now we won't connect this elements in any way, since we don't have information about what tracks we'll receive from the RTSP server which we're connecting with. |
Collaborator
There was a problem hiding this comment.
Suggested change
| As explained in the [Architecture chapter](08_RTSP_Architecture.md), the pipeline will consist of an RTSP Source and an HLS Sink Bin. For now we won't connect this elements in any way, since we don't have information about what tracks we'll receive from the RTSP server which we're connecting with. | |
| As explained in the [Architecture chapter](08_RTSP_Architecture.md), the pipeline will consist of an RTSP Source and an HLS Sink Bin. For now we won't connect this elements in any way, since we don't have information about what tracks we'll receive from the RTSP server which we're connecting to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.