fix(memory): handle inconsistent vector store return types #3682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _get_all_from_vector_store and _aget_all_from_vector_store methods now normalize varied return formats from vector stores (list, tuple, nested list) and handle None values to prevent crashes. Added a parameterized test suite to validate the fix against multiple data structure scenarios.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #3674
This pull request improves the robustness of the memory retrieval logic by normalizing the output from the vector store, ensuring consistent handling of various return types. It also adds comprehensive tests to verify this normalization across multiple scenarios.
Improvements to memory retrieval robustness:
_get_all_from_vector_storeinmem0/memory/main.pyto normalize the return value from the vector store. Now, the method handles cases where the result could be a tuple containing a list, a list of lists, or other nested structures, ensuringactual_memoriesis always a flat list. [1] [2]actual_memoriesto safely handle cases where it may beNoneor empty, preventing errors during iteration. [1] [2]Testing enhancements:
test_get_all_handles_various_return_typesintests/test_memory.pyto cover all expected return types from the vector store, including flat lists, tuples, nested lists, empty lists, andNone. This ensures the normalization logic works as intended for all supported scenarios.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.
Checklist:
Maintainer Checklist