Skip to content

Conversation

@matanco1
Copy link
Contributor

Description

Used score metadata for weaviate hybrid queries but always set score=1 as the code used distance instead of score
Fixed the issue by changing the if/else statement to use score

Also, changed the connection to weaviate cloud to the new interface introduced by the python package.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (does not change functionality, e.g. code style improvements, linting)

How Has This Been Tested?

All queries before returned score=1, now the score is settled.

Please delete options that are not relevant.

  • Test Script (can't provide, but the fix is very simple, I don't think you need it)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

Copy link
Contributor

@parshvadaftari parshvadaftari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@parshvadaftari parshvadaftari merged commit 517a266 into mem0ai:main Oct 1, 2025
6 of 7 checks passed
@parshvadaftari
Copy link
Contributor

Thank you for your contributions @matanco1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants