Skip to content

Allow any IP in the network#750

Merged
ja7ad merged 1 commit into
mainfrom
fix/v1.34-network-tests
Feb 3, 2026
Merged

Allow any IP in the network#750
ja7ad merged 1 commit into
mainfrom
fix/v1.34-network-tests

Conversation

@Strift
Copy link
Copy Markdown
Contributor

@Strift Strift commented Feb 3, 2026

Pull Request

Why

Fixes #748

How

  • Allow any IP in the Meilisearch network in test environments

PR checklist

Please check if your PR fulfills the following requirements:

  • Did you use any AI tool while implementing this PR (code, tests, docs, etc.)? If yes, disclose it in the PR description and describe what it was used for. AI usage is allowed when it is disclosed.
  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Summary by CodeRabbit

  • Chores
    • Enabled experimental IP network allowances across pre-release tests, integration tests, and deployment configurations.

@Strift Strift added the bug Something isn't working label Feb 3, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

These changes enable experimental IP network allowances across testing and deployment configurations by adding the --experimental-allowed-ip-networks=any flag to Meilisearch service startup commands, addressing network API test compatibility after breaking changes in Meilisearch 1.34.1.

Changes

Cohort / File(s) Summary
GitHub Workflow Configuration
.github/workflows/pre-release-tests.yml, .github/workflows/tests.yml
Adds --experimental-allowed-ip-networks=any flag to Docker run commands for Meilisearch Enterprise, enabling experimental network allowances during CI/CD test execution.
Docker Compose Configuration
docker-compose.yml
Adds MEILI_EXPERIMENTAL_ALLOWED_IP_NETWORKS=any environment variable to the meilisearch service for local development and deployment contexts.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Through networks vast, our tests now bound,
Experimental flags make magic sound,
Three files leap with synchronized cheer,
The API dances—breaking changes cleared! 🌐✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Allow any IP in the network' is vague and does not clearly convey what specific change or feature this PR implements. Consider using a more specific title like 'Enable experimental IP networks to fix network API tests' that clarifies both what changed and why.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR adds --experimental-allowed-ip-networks=any to Docker/compose configs to fix network API tests that broke in v1.34.1, directly addressing issue #748.
Out of Scope Changes check ✅ Passed All changes are focused on enabling experimental IP networks in test configurations to resolve the v1.34.1 breaking changes, with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/v1.34-network-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (5a9049d) to head (2853186).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
+ Coverage   88.41%   88.53%   +0.12%     
==========================================
  Files          22       22              
  Lines        3262     3262              
==========================================
+ Hits         2884     2888       +4     
+ Misses        220      216       -4     
  Partials      158      158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Strift Strift requested review from curquiza and ja7ad February 3, 2026 07:51
@ja7ad ja7ad added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit 7cf4a8b Feb 3, 2026
6 checks passed
@ja7ad ja7ad deleted the fix/v1.34-network-tests branch February 3, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v1.34] Fix network API tests

2 participants