Make index swap test more permissive

[Strift]

Fix Meilisearch 1.18 tests run

Summary by CodeRabbit

• Tests

  • Updated a JSON-related test to assert the serialized output contains the expected indexes array rather than matching exact JSON, making the test more resilient to formatting differences. No change to behavior or public APIs.

• Style

  • Minor indentation/formatting cleanup of test attribute annotations; no functional impact.

[coderabbitai]

Walkthrough

A unit test in tests/Meilisearch.Tests/IndexSwapTest.cs was updated to assert that the serialized JSON contains the expected "indexes" array instead of asserting full JSON equality. Minor indentation formatting was adjusted. No method signatures or public APIs were changed.

Changes

Cohort / File(s)	Summary
Tests – JSON assertion adjustment tests/Meilisearch.Tests/IndexSwapTest.cs	Replaced exact JSON equality assertion with Assert.Contains on the serialized JSON for the "indexes" array ("indexes":["indexA","indexB"]); adjusted attribute indentation; no signature or public API changes.

Sequence Diagram(s)

(omitted — changes are limited to a unit test assertion and do not modify control flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitched my whiskers at JSON’s might,
Now I nibble just the juicy byte—
“indexes” crunchy, pairs in view,
A lighter hop, a clearer cue.
Thump-thump! Tests pass in moonlit glow,
Carrots and asserts, onward we go. 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3490215 and 57b7fc3.

📒 Files selected for processing (1)

• tests/Meilisearch.Tests/IndexSwapTest.cs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/Meilisearch.Tests/IndexSwapTest.cs

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/fix-tests-after-v1.18

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

tests/Meilisearch.Tests/IndexSwapTest.cs (2)

18-18: Fix indentation of [Fact] attribute for consistency

The attribute is over-indented compared to the rest of the file. Align it with the surrounding members.

-                [Fact]
+        [Fact]

---

23-24: Prefer structural JSON assertion over substring containment

The switch to Assert.Contains makes the test less brittle than full JSON equality (good), but string-based JSON checks can still be flaky across serializers, formatting, or property ordering. Parsing the JSON and asserting on the "indexes" array keeps the test permissive while being robust to formatting differences.

-            var json = JsonSerializer.Serialize(swap);
-            Assert.Contains("\"indexes\":[\"indexA\",\"indexB\"]", json);
+            var json = JsonSerializer.Serialize(swap);
+            using var doc = JsonDocument.Parse(json);
+            var indexesEl = doc.RootElement.GetProperty("indexes");
+            Assert.Equal(JsonValueKind.Array, indexesEl.ValueKind);
+            Assert.Equal(2, indexesEl.GetArrayLength());
+            var values = new List<string>();
+            foreach (var el in indexesEl.EnumerateArray())
+            {
+                values.Add(el.GetString());
+            }
+            Assert.Equal(new[] { "indexA", "indexB" }, values);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8048c15 and 3490215.

📒 Files selected for processing (1)

• tests/Meilisearch.Tests/IndexSwapTest.cs (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

tests/Meilisearch.Tests/IndexSwapTest.cs (1)

tests/Meilisearch.Tests/MeilisearchClientTests.cs (16)

• Fact (35-40)
• Fact (42-47)
• Fact (49-65)
• Fact (67-73)
• Fact (75-80)
• Fact (82-93)
• Fact (95-106)
• Fact (108-124)
• Fact (126-142)
• Fact (144-155)
• Fact (158-163)
• Fact (165-171)
• Fact (173-178)
• Fact (180-186)
• Fact (188-194)
• Fact (196-205)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: integration-tests

[Strift]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[curquiza]

bors merge

[meili-bors]

Build succeeded:

• format-check
• integration-tests