Skip to content

Comments

Make RankingScoreThreshold optional#603

Merged
meili-bors[bot] merged 1 commit intomeilisearch:mainfrom
danFbach:bug-fix-601
Jan 8, 2025
Merged

Make RankingScoreThreshold optional#603
meili-bors[bot] merged 1 commit intomeilisearch:mainfrom
danFbach:bug-fix-601

Conversation

@danFbach
Copy link
Contributor

@danFbach danFbach commented Jan 8, 2025

Pull Request

Related issue

Fixes #601

What does this PR do?

  • make RankingScoreThreshold nullable (thereby optional and ignored by json convertor if left null)

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Passes all current integration tests.

@curquiza curquiza changed the title fixes #601 bug Make RankingScoreThreshold optional Jan 8, 2025
@curquiza curquiza added the bug Something isn't working label Jan 8, 2025
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jan 8, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit 4e4ce29 into meilisearch:main Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RankingScoreThreshold PR is unsupported on older meilisearch

2 participants