Merged
Conversation
Contributor
Author
|
Is it necessary to enforce the threshold range of |
curquiza
reviewed
Nov 27, 2024
curquiza
requested changes
Nov 27, 2024
| search_parameter_reference_ranking_score_threshold_1: |- | ||
| var params = new SearchQuery() | ||
| { | ||
| RankingScoreThreshold = 0.2M |
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
c# requires M when setting a decimal value. 0.2 is interpreted as a double and 0.2M is a decimal.
ex:
.code-samples.meilisearch.yaml
Outdated
| { | ||
| RankingScoreThreshold = 0.2M | ||
| }; | ||
| await client.Index("INDEX_NAME").SearchAsync<T>("badman", params); No newline at end of file |
Member
There was a problem hiding this comment.
Can you remove the "no new line" at the end of the line?
Member
There was a problem hiding this comment.
we follow the editorconfig rules
Member
|
Looks like there is an issue with the lining (cf CI) Can you fix this test? |
curquiza
approved these changes
Nov 27, 2024
Member
curquiza
left a comment
curquiza
left a comment
There was a problem hiding this comment.
Awesome!
thank you
bors merge
Contributor
|
Build succeeded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #544
What does this PR do?
RankingScoreThresholdSearchQueryparameter.PR checklist
Please check if your PR fulfills the following requirements: