Skip to content

Comments

Improve invalid API key handling#550

Merged
ahmednfwela merged 2 commits intomainfrom
fix/363
Jul 10, 2024
Merged

Improve invalid API key handling#550
ahmednfwela merged 2 commits intomainfrom
fix/363

Conversation

@ahmednfwela
Copy link
Collaborator

Pull Request

Related issue

Fixes #363
Supersedes #549

What does this PR do?

  • improve error message of MeilisearchTenantTokenApiKeyInvalid
  • improve constructor of TenantTokenRules to take IReadOnlyDictionary instead of a Dictionary
  • Added tests in TenantTokenTests.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@ahmednfwela ahmednfwela mentioned this pull request Jul 10, 2024
3 tasks
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brunoocasali
Copy link
Member

bors merge

@brunoocasali brunoocasali added the enhancement New feature or request label Jul 10, 2024
@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 10, 2024

Build succeeded:

@ahmednfwela ahmednfwela merged commit f97dd41 into main Jul 10, 2024
@ahmednfwela ahmednfwela deleted the fix/363 branch July 10, 2024 12:19
@curquiza curquiza changed the title fix: invalid API key handling Improve invalid API key handling Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating tenant tokens fails in .net 7 because of key size to small

2 participants