Add support for text-separator customization#537
Merged
meili-bors[bot] merged 5 commits intomeilisearch:mainfrom May 22, 2024
Merged
Add support for text-separator customization#537meili-bors[bot] merged 5 commits intomeilisearch:mainfrom
meili-bors[bot] merged 5 commits intomeilisearch:mainfrom
Conversation
16b3189 to
133cf52
Compare
ahmednfwela
requested changes
May 21, 2024
Collaborator
ahmednfwela
left a comment
There was a problem hiding this comment.
Thanks for the PR
One change I would like to suggest, is that in general it's better to use IEnumerable<...> for function inputs and List<...> for function outputs
so for example:
public async Task<List<string>> GetSeparatorTokensAsync(CancellationToken cancellationToken = default)and
public async Task<TaskInfo> UpdateNonSeparatorTokensAsync(IEnumerable<string> nonSeparatorTokens, CancellationToken cancellationToken = default)
Contributor
Author
I agree 👍 |
9dd1899 to
6979f66
Compare
ahmednfwela
approved these changes
May 21, 2024
Collaborator
|
bors merge |
Contributor
|
Build succeeded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #482
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!