Skip to content

Conversation

@Naimul007A
Copy link

Enhances the calendar filter component with improved preset handling and timezone support.

Changes

  • Custom Preset: Added a new "Custom" preset option that is automatically selected when dates don't match predefined ranges
  • Auto-Detection: Implemented detectPreset() function to intelligently detect and highlight the active preset based on current date range
  • Local Timezone: Changed date formatting to use local timezone (toLocaleDateString) instead of ISO format to prevent timezone conversion issues
  • Initialization: Improved component initialization to properly set temporary dates and detect current preset on mount

Benefits

  • Users can now see which preset is currently active
  • Better handling of custom date ranges
  • Eliminates timezone-related date shifting issues
  • More intuitive user experience when switching between presets

Fixes #67

- Add custom preset option for manual date selection
- Implement automatic preset detection based on date ranges
- Switch to local timezone formatting for date handling
- Initialize temp dates on component mount

Fixes me-shaon#67
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Naimul007A, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the calendar filter component by adding a "Custom" preset for flexible date selection and implementing an intelligent auto-detection mechanism to highlight the active preset. Crucially, it resolves timezone-related discrepancies by ensuring dates are formatted according to the local timezone, leading to a more accurate and user-friendly date filtering experience.

Highlights

  • Custom Preset Option: Introduced a 'Custom' preset that automatically activates when selected dates don't match predefined ranges, enhancing flexibility for users.
  • Preset Auto-Detection: Added a detectPreset() function to intelligently identify and highlight the currently active date range preset based on the selected start and end dates.
  • Timezone Fixes: Switched date formatting from ISO to toLocaleDateString to correctly handle local timezones and prevent date shifting issues, ensuring accurate date display.
  • Improved Initialization: Enhanced the component's init() method to properly set temporary dates and detect the initial preset upon loading, providing a more consistent user experience.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces useful enhancements to the calendar filter, including auto-detection of presets and fixes for timezone issues. The implementation is generally good, but I've identified a few areas for improvement to enhance correctness and maintainability.

My review includes feedback on:

  • A potential issue with a duplicate key in the PHP presets array.
  • A critical bug in the quarter_to_date preset detection logic, for which I've provided a fix.
  • Unsafe date string parsing in JavaScript, which can lead to timezone-related errors. I've suggested a more robust approach.
  • A minor code cleanup to remove commented-out code.

Addressing these points will make the component more robust and reliable. Thank you for the contribution!

@me-shaon
Copy link
Owner

@Naimul007A can you please check the review comments and fix them?

@Naimul007A
Copy link
Author

@Naimul007A can you please check the review comments and fix them?

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Filter Selection Always Defaults to “30 Days”

2 participants