fix: pass through remarkConfigPath of parserOptions#591
Conversation
🦋 Changeset detectedLatest commit: 19769d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the remark ESLint rule by adding support for a custom remarkConfigPath passed through parserOptions, and refactors how related options are typed and forwarded.
- Destructure and extract
ignoreRemarkConfigandremarkConfigPathfromparserOptions - Forward
remarkConfigPathintoperformSyncWork - Refactor
ParserOptionsandSyncOptionsin types to share a newCommonOptionsinterface
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/eslint-plugin-mdx/src/rules/remark.ts | Destructure new options (ignoreRemarkConfig, remarkConfigPath) and pass remarkConfigPath to the worker |
| packages/eslint-mdx/src/types.ts | Introduce CommonOptions for shared fields and update ParserOptions/SyncOptions to extend it |
| .changeset/wise-spiders-suffer.md | Add a changeset entry noting the patch for passing through remarkConfigPath |
Comments suppressed due to low confidence (1)
packages/eslint-plugin-mdx/src/rules/remark.ts:65
- Add a unit test to verify that
remarkConfigPathprovided viaparserOptionsis correctly forwarded toperformSyncWork, ensuring the custom config path is honored.
remarkConfigPath,
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #591 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 275 273 -2
Branches 47 47
=========================================
- Hits 275 273 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Initial checklist
Description of changes
TODO