Update to Tapenade 3.16 #312
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #312 +/- ##
=======================================
Coverage 41.98% 41.98%
=======================================
Files 13 13
Lines 4001 4001
=======================================
Hits 1680 1680
Misses 2321 2321 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lamkina
approved these changes
Sep 13, 2023
lamkina
left a comment
There was a problem hiding this comment.
I tested the updated build process and ran derivative checks with simple test cases and a MACH-only version of my aeroprop case. Derivatives look good and the tapenade build worked as expected.
marcomangano
approved these changes
Sep 13, 2023
marcomangano
left a comment
Collaborator
There was a problem hiding this comment.
I also tested this on my side and everything looks good
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates the AD'd files to the latest Tapenade version along with the latest ADFirstAidKit files.
Few things to note, regarding this version of Tapenade. This version creates nonstandard type declarations, so postprocessing steps are added in
autoEditscripts. Additionally, Tapenade seems for some reason to miss theetot_dfunction ininviscidupwindflux_d(same for reverse) so its added back.Please review carefully and preferably run and test this on actual cases (aside from the unit/regression tests) to make sure derivatives have not regressed in some edge cases.
Expected time until merged
No rush
Type of change
Testing
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable