Skip to content

Correct usage of ellipsis, part 3 #18172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
teoli2003 merged 2 commits into from
Jul 10, 2022
Merged

Correct usage of ellipsis, part 3 #18172

teoli2003 merged 2 commits into from
Jul 10, 2022

Conversation

@OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Jul 10, 2022

Adding to #18170.

@OnkarRuikar OnkarRuikar requested review from a team as code owners July 10, 2022 07:10
@OnkarRuikar OnkarRuikar requested review from sideshowbarker and removed request for a team July 10, 2022 07:10
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Jul 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 31 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/XRFrame/getJointPose
Title: XRFrame.getJointPose()
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.XRFrame.getJointPose

URL: /en-US/docs/Web/API/Request
Title: Request
on GitHub
Flaw count: 2

  • bad_bcd_links:
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/Window/openDialog
Title: Window.openDialog()
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/Window/arguments does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Add-ons/Code_snippets/Dialogs_and_Prompts#passing_arguments_and_displaying_a_dialog
    • Can't resolve /en-US/docs/Mozilla/Add-ons/Code_snippets/Dialogs_and_Prompts#passing_arguments_and_displaying_a_dialog
    • Can't resolve /en-US/docs/Archive/Web/Window.importDialog

URL: /en-US/docs/Web/API/Window/window
Title: Window.window
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/JavaScript_code_modules

URL: /en-US/docs/Web/API/Animation/startTime
Title: Animation.startTime
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Timeline does not exist

URL: /en-US/docs/MDN/Structures/Page_types/API_reference_page_template
Title: API reference page template
on GitHub
Flaw count: 10

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
    • /en-US/docs/Web/API/NameOfTheInterface/NameOfTheInterface does not exist
    • /en-US/docs/Web/API/NameOfTheInterface does not exist
    • /en-US/docs/Web/API/NameOfParentInterface does not exist
    • /en-US/docs/Web/API/NameOfTheInterface/property1 does not exist
    • and 4 more flaws omitted
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheInterface

URL: /en-US/docs/MDN/Guidelines/Writing_style_guide
Title: Writing style guide
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/HTML/Element/h2 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /en-US/docs/Web/HTML/Element/h3 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /en-US/docs/Web/HTML/Element/h4 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements

External URLs

URL: /en-US/docs/Web/API/Element/innerHTML
Title: Element.innerHTML
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/DragEvent/dataTransfer
Title: DragEvent.dataTransfer
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaError/msExtendedCode
Title: MediaError.msExtendedCode
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/File_API/Using_files_from_web_applications
Title: Using files from web applications
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Touch/clientX
Title: Touch.clientX
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Touch/clientY
Title: Touch.clientY
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/File/lastModifiedDate
Title: File.lastModifiedDate
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/File/lastModified
Title: File.lastModified
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document/hidden
Title: Document.hidden
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document/requestStorageAccess
Title: Document.requestStorageAccess()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Document/visibilityState
Title: Document.visibilityState
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Sanitizer/sanitizeFor
Title: Sanitizer.sanitizeFor()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRView/transform
Title: XRView.transform
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRView/isFirstPersonObserver
Title: XRView.isFirstPersonObserver
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Response/json
Title: Response.json()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRFrame/getDepthInformation
Title: XRFrame.getDepthInformation()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/XRFrame/getJointPose
Title: XRFrame.getJointPose()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Request
Title: Request
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Request/json
Title: Request.json()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Event/timeStamp
Title: Event.timeStamp
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Event/bubbles
Title: Event.bubbles
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Window/openDialog
Title: Window.openDialog()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Window/postMessage
Title: Window.postMessage()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Window/unhandledrejection_event
Title: Window: unhandledrejection event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Window/window
Title: Window.window
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/fetch
Title: fetch()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/FormData/Using_FormData_Objects
Title: Using FormData Objects
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Animation/startTime
Title: Animation.startTime
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Animation/currentTime
Title: Animation.currentTime
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Macros/Commonly-used_macros
Title: Commonly-used macros
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_reference_page_template
Title: API reference page template
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Tools/KumaScript
Title: KumaScript
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Kitchensink
Title: The MDN Content Kitchensink
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Guidelines/Writing_style_guide
Title: Writing style guide
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Guidelines/Code_guidelines/Shell
Title: Shell prompt guidelines
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Contribute/Processes/Short_surveys
Title: Process for running short surveys
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Contribute/Howto/Write_an_API_reference
Title: How to write an API reference
on GitHub

No new external URLs

URL: /en-US/docs/MDN/At_ten/History_of_MDN
Title: The History of MDN
on GitHub

No new external URLs

(this comment was updated 2022-07-10 08:38:33.676591)

teoli2003
teoli2003 suggested changes Jul 10, 2022
View reviewed changes
files/en-us/web/api/dragevent/datatransfer/index.md
```js
function processData(d) {
// Process the data ...
// Process the data …
Copy link
Contributor

@teoli2003 teoli2003 Jul 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Process the data …
// Process the data…

@OnkarRuikar @teoli2003
Apply suggestions from code review
905f8f2 
Co-authored-by: Jean-Yves Perrier <[email protected]>
@teoli2003 teoli2003 merged commit 356b065 into mdn:main Jul 10, 2022
@OnkarRuikar OnkarRuikar deleted the ellipsis2 branch July 10, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker was automatically assigned from mdn/yari-content-web-api

1 more reviewer

@teoli2003 teoli2003 teoli2003 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OnkarRuikar @teoli2003