-
Notifications
You must be signed in to change notification settings - Fork 23.1k
update mdn teams in Localize #16990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update mdn teams in Localize #16990
Conversation
Preview URLsFlawsNone! 🎉 External URLsURL:
(this comment was updated 2022-06-27 15:22:52.858343) |
|
Hello @mdn/localization-team-leads, please take a look at the changes to verify if all updates look good. Thank you! |
hochan222
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for ko locale :)
|
|
|
Friendly ping for review @dipikabh - Thanks |
Co-authored-by: Juan Vásquez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that the Spanish team has at at the beginning of the name and I was wondering if all teams should have the same format or we should use the formal name as the pt-BR has, (just to be consistent)
I'm also not really sure about this. Does anyone have suggestions? |
|
I'd say GitHub does not necessarily present usernames with an @ (see on https://github.com/SphinxKnight) (contrary to Twitter for instance) and that the current page works without an @: https://developer.mozilla.org/en-US/docs/MDN/Contribute/Localize) In my (not so strong) opinion, one could go without @ for the sake of GH users' mentions consistency and lightness. |
Co-authored-by: Juan Vásquez <[email protected]>
dipikabh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks everyone!
Summary
update mdn teams in MDN/Contribute/Localize
Metadata