Skip to content

Conversation

@yin1999
Copy link
Member

@yin1999 yin1999 commented Jun 5, 2022

Summary

update mdn teams in MDN/Contribute/Localize

Metadata

  • Fixes a typo, bug, or other error

@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Jun 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2022

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/MDN/Contribute/Localize
Title: Localizing MDN
on GitHub

(this comment was updated 2022-06-27 15:22:52.858343)

@yin1999 yin1999 marked this pull request as ready for review June 5, 2022 02:28
@yin1999 yin1999 requested a review from a team as a code owner June 5, 2022 02:28
@yin1999 yin1999 requested review from dipikabh and removed request for a team June 5, 2022 02:28
@dipikabh
Copy link
Contributor

dipikabh commented Jun 7, 2022

Hello @mdn/localization-team-leads, please take a look at the changes to verify if all updates look good. Thank you!

Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ko locale :)

@SphinxKnight
Copy link
Contributor

fr untouched so OK ^ ^

@schalkneethling
Copy link

Friendly ping for review @dipikabh - Thanks

Co-authored-by: Juan Vásquez <[email protected]>
Copy link
Member

@JuanVqz JuanVqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that the Spanish team has at at the beginning of the name and I was wondering if all teams should have the same format or we should use the formal name as the pt-BR has, (just to be consistent)

@yin1999
Copy link
Member Author

yin1999 commented Jun 27, 2022

I saw that the Spanish team has at at the beginning of the name and I was wondering if all teams should have the same format or we should use the formal name as the pt-BR has, (just to be consistent)

I'm also not really sure about this. Does anyone have suggestions?

@SphinxKnight
Copy link
Contributor

I'd say GitHub does not necessarily present usernames with an @ (see on https://github.com/SphinxKnight) (contrary to Twitter for instance) and that the current page works without an @: https://developer.mozilla.org/en-US/docs/MDN/Contribute/Localize)

In my (not so strong) opinion, one could go without @ for the sake of GH users' mentions consistency and lightness.

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone!

@dipikabh dipikabh merged commit 88b02ff into mdn:main Jun 27, 2022
@yin1999 yin1999 deleted the update-mdn-teams branch June 28, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Other Any docs not covered by another "Content:" label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants