Skip to content

properly unify payload/blob returning in API, add proofs to blob bundle, reject 0-blob blob txs #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

properly unify payload/blob returning in API, add proofs to blob bundle, reject 0-blob blob txs #122

merged 1 commit into from
Apr 21, 2023

Conversation

@roberto-bayardo
Copy link
Collaborator

@roberto-bayardo roberto-bayardo commented Apr 21, 2023 •
edited
Loading

@roberto-bayardo roberto-bayardo changed the title properly unify payload/blob returning in API, add proofs to blob bundle properly unify payload/blob returning in API, add proofs to blob bundle, reject 0-blob blob txs Apr 21, 2023
@roberto-bayardo roberto-bayardo force-pushed the merge-getblob-getpayload branch from a5f133e to a850b4c Compare April 21, 2023 21:16
@roberto-bayardo roberto-bayardo marked this pull request as ready for review April 21, 2023 21:19
@roberto-bayardo roberto-bayardo requested a review from Inphi April 21, 2023 21:20
@roberto-bayardo roberto-bayardo force-pushed the merge-getblob-getpayload branch 2 times, most recently from 0fe5c14 to e177285 Compare April 21, 2023 21:24
Inphi
Inphi reviewed Apr 21, 2023
View reviewed changes
@roberto-bayardo roberto-bayardo force-pushed the merge-getblob-getpayload branch from e177285 to 2dd2f83 Compare April 21, 2023 22:07
@roberto-bayardo roberto-bayardo requested a review from Inphi April 21, 2023 22:08
@roberto-bayardo roberto-bayardo force-pushed the merge-getblob-getpayload branch from 2dd2f83 to 7caa0ba Compare April 21, 2023 22:09
Inphi
Inphi approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roberto-bayardo roberto-bayardo merged commit 47cf187 into eip-4844 Apr 21, 2023
@roberto-bayardo roberto-bayardo deleted the merge-getblob-getpayload branch April 21, 2023 22:35
@spencer-tb spencer-tb mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Inphi Inphi Inphi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roberto-bayardo @Inphi