Fix binary response handling with regex conditions#18
Merged
mcustiel merged 1 commit intoDec 27, 2024
Merged
Conversation
mcustiel
approved these changes
Dec 19, 2024
Owner
mcustiel
left a comment
There was a problem hiding this comment.
Nice catch. And thank you for taking care and covering it with tests ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using regex conditions (for URL or body) with binary response body, the content was incorrectly returned as a string with 'phiremock.base64:' prefix instead of actual binary data.
This PR fixes the issue by:
The change ensures binary responses (like images) are properly handled regardless of whether regex conditions are used in the expectation.