Supporting different themes #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Contributor
Author
|
Oh, yes makes sense. I will look into it as soon as possible, but could take some days. |
Contributor
Author
|
@mbrlabs looks like the conflict is resolved. Hope everything works still as expected. :-) |
Owner
|
Thanks, seems to work great! Some UI elements are still dark (buttons, text inputs and tabs) but that can be fixed later. Good starting point 👍 |
Contributor
Author
|
Oh and the checkbox fix is only in the dark theme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a light theme and the possibility to switch it in the settings. Implementation was done as described in issue #23