-
-
Notifications
You must be signed in to change notification settings - Fork 287
Adding Label/TextBoxes to Lorien #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… save/load function
|
So I have fixed the merge conflict and also added the new theme change function to the text editor. @mbrlabs this is probably also only a starting point for the full feature, but I would like to know, what you think about it. |
|
Very nice work! I haven't looked at the code yet in detail but this already kinda works like i would expect. However i can't edit/change any text after i added it...might be broken. Anyway, i'm gonna have a closer look this later this weekend :) |
|
Thanks 🙂 I will check if the edit is broken, but I think it was working when I fixed the merge conflict. Right now you need to have the Textbox Tool active and click on a Text, then the Popup should contain the text and you can edit it. Probably it would be better, that a double click with the select tool would trigger it. The code probably needs another round of cleanup. 😅 |
|
I thought a bit more about the UI. How hard would it be to completly get rid of the dialog and do the editing directly on the canvas? Like this:
If you want to edit it afterwards you just click on it again with the text tool active and start editing |
|
🤔 i think it would make sense. I created an editor, that possible font/text size changes could be handled within the editor. But that could probably also be handled with selecting the text and change it then. I can try to implement it, but it will take some time I guess. 🤔 |
|
Yeah i would not worry too much about editing font size etc right now. That can be added later. Maybe even to the toolbar. The toolbar could be adaptive to only show the settings of the current tool. I would say go for it if you want to give it a try. No worries, take your time. It's much better from a UX point of view. |
|
Sure, I'll give it a try. |
|
Quick update, I tried to implement it with an TextEdit, but I run in some issues with it.
So I have to investigate a bit more, to get the better looking solution to work. |
I have created a very basic implementation of text boxes/labels.
What is working:
What could be improved in the future:
This should solve the basic needs of Issue #63 .
I hope it is useful for the users and the product.