Minor parsing fixes + new HPC#1
Merged
mb010 merged 6 commits intomb010:HPC_parameterfrom Apr 28, 2022
Merged
Conversation
Owner
|
Hi @AlecThomson, I'll test the changes soon. I'm pretty busy atm, so probably in a few weeks. |
Author
|
Found one extra, but nasty, bug. Thanks to a lower case |
Owner
|
Sorry it took me so long to get back to this and review it. Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mb010,
Thanks for this adaptation of the pipeline!
Just adding a couple of fixes to your PR. These were pretty minor, but caused a couple of trip ups in my testing.
I've also just added the system I was using for good measure.