-
Notifications
You must be signed in to change notification settings - Fork 179
Ignore un-supported events that backend services might send #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ssages from Yandex metrics
✅ Deploy Preview for getmavo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
It looks like Madata also suffers from this issue. |
LeaVerou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, this didn't even need a review IMO
I’m not surprised. In fact, we're so close to being able to use ESM in Mavo, that I'm wondering if there's much point in creating new Mavo backends at all. |
People from the Russian Mavo community asked me to build it. And since I would love them to continue using Mavo, I agreed. |
I can fix it there too if you don't mind. |
Please do :) |
E.g., messages from Yandex metrics
E.g., messages from Yandex metrics
Working on the new Yandex Disk backend, I noticed that it sends an extra message event to the
authPopupwindow while authenticating the user. Yandex Metrics sends this message. The event doesn't contain thebackendfield in the payload, neither does it containaccessTokenand breaks the login flow since wereject(Error("Authentication error"))in such cases.Let's ignore all
messageevents that don't serve the authentication purpose.