Skip to content

Conversation

@DmitrySharabin
Copy link
Member

Working on the new Yandex Disk backend, I noticed that it sends an extra message event to the authPopup window while authenticating the user. Yandex Metrics sends this message. The event doesn't contain the backend field in the payload, neither does it contain accessToken and breaks the login flow since we reject(Error("Authentication error")) in such cases.

Let's ignore all message events that don't serve the authentication purpose.

@netlify
Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for getmavo ready!

Name Link
🔨 Latest commit d06ce6e
🔍 Latest deploy log https://app.netlify.com/sites/getmavo/deploys/65439a6f3322390008b1e00b
😎 Deploy Preview https://deploy-preview-991--getmavo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DmitrySharabin
Copy link
Member Author

It looks like Madata also suffers from this issue.

Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, this didn't even need a review IMO

@LeaVerou
Copy link
Member

LeaVerou commented Nov 2, 2023

It looks like Madata also suffers from this issue.

I’m not surprised.

In fact, we're so close to being able to use ESM in Mavo, that I'm wondering if there's much point in creating new Mavo backends at all.

@DmitrySharabin
Copy link
Member Author

In fact, we're so close to being able to use ESM in Mavo that I'm wondering if there's much point in creating new Mavo backends at all.

People from the Russian Mavo community asked me to build it. And since I would love them to continue using Mavo, I agreed. ☺️
If it works in Mavo well (as a starting point), there is not much effort to port it to Madata later. From my perspective, it's a win-win.

@DmitrySharabin DmitrySharabin merged commit 559d477 into main Nov 2, 2023
@DmitrySharabin
Copy link
Member Author

I’m not surprised.

I can fix it there too if you don't mind.

@DmitrySharabin DmitrySharabin deleted the backend-services branch November 2, 2023 14:30
@LeaVerou
Copy link
Member

LeaVerou commented Nov 2, 2023

I’m not surprised.

I can fix it there too if you don't mind.

Please do :)

DmitrySharabin added a commit that referenced this pull request Jun 28, 2024
DmitrySharabin added a commit that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants