Convert QGroundControl.Controls to qt_add_qml_module#12931
Merged
Conversation
DonLakeFlyer
force-pushed
the
ControlsModule
branch
2 times, most recently
from
cf26ac1 to
7fb65ac
Compare
This will compile qml for performance boost Move qml file to QmlControls directory to avoid use of QT_RESOURCE_ALIAS. There appears to be some sort of Qt bug/feature which causes this to not work correctly on Windows builds. This is the simplest fix nor now which requires minimal code churn.
DonLakeFlyer
force-pushed
the
ControlsModule
branch
from
7fb65ac to
77daa00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will compile qml for performance boost.
This one was a real PITA. I think I can guarantee I broke something that I missed during inspection and testing. We'll see...