TCP: Allow connecting by hostname #2053
Conversation
JonasVautherin
force-pushed
the
tcp-by-host
branch
from
1f36d94 to
67a0f66
Compare
JonasVautherin
left a comment
JonasVautherin
left a comment
There was a problem hiding this comment.
Nice! I fixed the style, and the other CI issues seem unrelated to this PR.
julianoes
left a comment
julianoes
left a comment
There was a problem hiding this comment.
Any chance you can add the same for Windows while you're at it?
| remote_addr.sin_addr.s_addr = inet_addr(_remote_ip.c_str()); | ||
|
|
||
| struct hostent* hp; | ||
| hp = gethostbyname(_remote_ip.c_str()); |
There was a problem hiding this comment.
| hp = gethostbyname(_remote_ip.c_str()); | |
| struct hostent* hp; = gethostbyname(_remote_ip.c_str()); |
As I read it, this doesn't need cleaning up, right?
There was a problem hiding this comment.
No appranently this points to static memory
|
I believe this should work for windows as well - does the windows CI test open a TCP connection? Otherwise I'd need to to test a real windows machine. |
|
CI likely doesn't test it. I'll try to test on Windows some time but you might beat me to it. |
|
@ThomasDebrunner sorry for the delay. Trying to build and run this on Windows caused some work 😄, see #2069. So, anyway, let me just merge it. |
3 participants
This allows TCP connections to be made by hostname, not just IP - e.g.
tcp://localhost:1234, ortcp://my-device.local:1234Tested on linux and macos