remote_id: open drone id plugin interface #327
Conversation
julianoes
left a comment
julianoes
left a comment
There was a problem hiding this comment.
Thanks for your PR @persuader72. I'm appalled by the OpenDrone ID MAVLink messages, now that I look at them in detail but a well, too late now, I suppose.
However, we have to figure out which things we want to expose raw and what we can hide and make easier.
JonasVautherin
left a comment
JonasVautherin
left a comment
There was a problem hiding this comment.
A few nitpicks 😇.
|
With the "ArmStatus" stream i think that the feature set is completed |
julianoes
left a comment
julianoes
left a comment
There was a problem hiding this comment.
I think this looks persuading 😄
| enum VerAcc { | ||
| VER_ACC_UNKNOWN = 0; // The vertical accuracy is unknown. | ||
| VER_ACC_METER_150 = 1; // The vertical accuracy is smaller than 150 meter. | ||
| VER_ACC_METER_45 = 2; // The vertical accuracy is smaller than 45 meter. | ||
| VER_ACC_METER_25 = 3; // The vertical accuracy is smaller than 25 meter. | ||
| VER_ACC_METER_10 = 4; // The vertical accuracy is smaller than 10 meter. | ||
| VER_ACC_METER_3 = 5; // The vertical accuracy is smaller than 3 meter. | ||
| VER_ACC_METER_1 = 6; // The vertical accuracy is smaller than 1 meter. | ||
| } |
There was a problem hiding this comment.
Still puzzles my why they wouldn't just use a uint8 to signal meter accuracy... but anyway, I think I can live with that.
There was a problem hiding this comment.
I think the reasons are historic. In some radio broadcasting ID protocols (like AIS or ADSB) the accuracy is an enumerative type or is rounded to less than 8 bits to save space (then save bandwidth)
|
@julianoes, It is better to rewrite the history of this PR in one single commit? |
|
@persuader72 Feel free to rewrite the history and force push. If you don't, then I'll just squash-merge it. |
persuader72
force-pushed
the
remote_id
branch
from
858de5e to
415ab27
Compare
|
Sorry, this disappeared off my radar. I will review again ASAP! |
|
@julianoes @persuader72 Is it possible to merge this? |
|
Sorry yes, I need to work through this. I have it planned as soon as v3 is done (see mavlink/MAVSDK#2316). |
|
@julianoes Now that v3 is done any chance you have cycles for this again? |
|
Might as well, thanks for the reminder! I'll review |
julianoes
left a comment
julianoes
left a comment
There was a problem hiding this comment.
I think I can live with this.
|
@persuader72 are you still interested in finishing this? |
|
@julianoes It's not clear to me what's needed to get this over the line but I would be interested in finishing the work if you can provide some guidance. |
|
Sorry for the late reply , yes In the next days I have some time to spend in this activity, @aheyne if you want we can split the work to finish the module. |
|
@persuader72 can you make a pull request for the C++ MAVSDK part? |
5 participants
Proto file for the remote_id protocol.
This proto file is need by the new remote_id MAVSDK plugin.
The goal of the plugin to use the companion computer to work with open drone id compatible hardware like this even is the autopilot is not compatible with such protocol.