Conversation
So far Mimir offered (and was quite reluctant) to cache anything else than direct Central. Open this up, as Central is becoming "non-special".
bmarwell
approved these changes
Dec 5, 2025
bmarwell
left a comment
bmarwell
left a comment
There was a problem hiding this comment.
except a nit, can't wait to test it
Comment on lines
+47
to
+82
| Predicate<RemoteRepository> result = null; | ||
| for (String repoSpec : repositories) { | ||
| Predicate<RemoteRepository> repoPredicate; | ||
| if (!repoSpec.contains("(") && !repoSpec.contains(")")) { | ||
| if ("*".equals(repoSpec)) { | ||
| repoPredicate = release(); | ||
| } else { | ||
| repoPredicate = idOnly(repoSpec).and(release()); | ||
| } | ||
| } else if (repoSpec.contains("(") && repoSpec.contains(")")) { | ||
| String repoId = repoSpec.substring(0, repoSpec.indexOf("(")); | ||
| if ("*".equals(repoId)) { | ||
| repoPredicate = r -> true; | ||
| } else { | ||
| repoPredicate = idOnly(repoId); | ||
| } | ||
| if (repoSpec.contains(MOD_HTTPS_ONLY)) { | ||
| repoPredicate = repoPredicate.and(httpsOnly()); | ||
| } | ||
| if (repoSpec.contains(MOD_DIRECT_ONLY)) { | ||
| repoPredicate = repoPredicate.and(directOnly()); | ||
| } | ||
| if (repoSpec.contains(MOD_RELEASE_ONLY)) { | ||
| repoPredicate = repoPredicate.and(releaseOnly()); | ||
| } else { | ||
| repoPredicate = repoPredicate.and(release()); | ||
| } | ||
| } else { | ||
| throw new IllegalStateException("Invalid repository spec: " + repoSpec); | ||
| } | ||
| if (result == null) { | ||
| result = repoPredicate; | ||
| } else { | ||
| result = result.or(repoPredicate); | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
Why? All the parsing, constants and parsing result (predicates) are in single class? What would give factoring out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far Mimir offered (and was quite reluctant) to cache anything else than direct Central. Open this up, as Central is becoming "non-special".