Skip to content

Fix invalid construction of greedy sampler in LlamaLanguageModel #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattt merged 2 commits into from
Dec 10, 2025
Merged

Fix invalid construction of greedy sampler in LlamaLanguageModel #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e213b3
Fix invalid construction of greedy sampler in LlamaLanguageModel
mattt Dec 10, 2025
73f7977
Construct model once in LlamaLanguageModelTests
mattt Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/AnyLanguageModel/Models/LlamaLanguageModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,7 @@ import Foundation
case .greedy:
llama_sampler_chain_add(sampler, llama_sampler_init_top_k(1))
llama_sampler_chain_add(sampler, llama_sampler_init_top_p(1.0, 1))
llama_sampler_chain_add(sampler, llama_sampler_init_greedy())
case .topK(let k, let seed):
llama_sampler_chain_add(sampler, llama_sampler_init_top_k(Int32(k)))
llama_sampler_chain_add(sampler, llama_sampler_init_top_p(1.0, 1))
Expand Down
25 changes: 5 additions & 20 deletions Tests/AnyLanguageModelTests/LlamaLanguageModelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,11 @@ import Testing
.enabled(if: ProcessInfo.processInfo.environment["LLAMA_MODEL_PATH"] != nil)
)
struct LlamaLanguageModelTests {
let modelPath: String = ProcessInfo.processInfo.environment["LLAMA_MODEL_PATH"] ?? ""

var model: LlamaLanguageModel {
LlamaLanguageModel(
modelPath: modelPath,
contextSize: 2048,
temperature: 0.8
)
}
let model = LlamaLanguageModel(
modelPath: ProcessInfo.processInfo.environment["LLAMA_MODEL_PATH"]!,
contextSize: 2048,
temperature: 0.8
)

@Test func initialization() {
let customModel = LlamaLanguageModel(
Expand Down Expand Up @@ -102,17 +98,6 @@ import Testing
#expect(!secondResponse.content.isEmpty)
}

@Test func customTemperature() async throws {
let highTempModel = LlamaLanguageModel(
modelPath: modelPath,
temperature: 1.5
)

let session = LanguageModelSession(model: highTempModel)
let response = try await session.respond(to: "Say something creative")
#expect(!response.content.isEmpty)
}

@Test func maxTokensLimit() async throws {
let session = LanguageModelSession(model: model)

Expand Down