Add logic to handle encoder-only llama models #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for detecting and handling encoder-only language models (like BERT) in the LlamaLanguageModel implementation. The changes prevent text generation attempts with encoder-only models by introducing early detection and proper error handling, while also adding logic to support encoder-decoder models (like T5).
Key changes:
- Added new
encoderOnlyModelerror case to properly reject text generation for encoder-only models - Implemented encoder/decoder model type detection using llama.cpp API functions
- Added separate code paths for encoder-decoder models vs standard decoder-only models with proper token handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Dec 10, 2025
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mattt
force-pushed
the
mattt/llama-detect-encoder-only
branch
from
fd1c791 to
9747a25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #51